Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14175016: Change to update panel positions after panels moved to the new collection when the unstacking happe… (Closed)

Created:
7 years, 8 months ago by jianli
Modified:
7 years, 8 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, dcheng
Visibility:
Public.

Description

Change to update panel positions after panels moved to the new collection when the unstacking happens When the unstacking happens, we should first move the panels to the new collection and then update their positions. If we're update panel positions first, the existing stack window will enclose 2 sets of panels that are not aligned which causes the background window to be seen. BUG=223155 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M chrome/browser/ui/panels/panel_drag_controller.cc View 10 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jianli
7 years, 8 months ago (2013-04-18 00:09:21 UTC) #1
Dmitry Titov
lgtm
7 years, 8 months ago (2013-04-19 17:37:42 UTC) #2
jianli
7 years, 8 months ago (2013-04-19 22:14:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r195307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698