Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 14175015: Allow VideoCaptureImpl to suspend/resume frame delivery to its client. (Closed)

Created:
7 years, 8 months ago by wjia(left Chromium)
Modified:
7 years, 8 months ago
Reviewers:
jamesr, qinmin
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, leozwang1
Visibility:
Public.

Description

Allow VideoCaptureImpl to suspend/resume frame delivery to its client. On Android, when WebRTC tab goes background, we need suspend video frame delivery to remote party. When WebRTC tab becomes foreground, VideoCaptureImpl needs to resume delivering captured video frames. BUG=230962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194374

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M content/renderer/media/video_capture_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 4 chunks +15 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl_manager.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wjia(left Chromium)
7 years, 8 months ago (2013-04-12 22:25:24 UTC) #1
wjia(left Chromium)
7 years, 8 months ago (2013-04-12 23:02:42 UTC) #2
qinmin
lgtm https://codereview.chromium.org/14175015/diff/1/content/renderer/media/video_capture_impl_manager.cc File content/renderer/media/video_capture_impl_manager.cc (right): https://codereview.chromium.org/14175015/diff/1/content/renderer/media/video_capture_impl_manager.cc#newcode42 content/renderer/media/video_capture_impl_manager.cc:42: for (Devices::iterator it = devices_.begin(); it != devices_.end(); ...
7 years, 8 months ago (2013-04-16 04:06:17 UTC) #3
wjia(left Chromium)
+jamesr@ for owner's stamp on content/renderer/render_view_impl.cc. https://codereview.chromium.org/14175015/diff/1/content/renderer/media/video_capture_impl_manager.cc File content/renderer/media/video_capture_impl_manager.cc (right): https://codereview.chromium.org/14175015/diff/1/content/renderer/media/video_capture_impl_manager.cc#newcode42 content/renderer/media/video_capture_impl_manager.cc:42: for (Devices::iterator it ...
7 years, 8 months ago (2013-04-16 16:44:04 UTC) #4
wjia(left Chromium)
+jamesr@ for owner's stamp on content/renderer/render_view_impl.cc.
7 years, 8 months ago (2013-04-16 16:45:01 UTC) #5
jamesr
content/renderer/render_view_impl lgtm
7 years, 8 months ago (2013-04-16 16:58:48 UTC) #6
wjia(left Chromium)
7 years, 8 months ago (2013-04-16 16:59:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r194374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698