New GC related APIs: Implicit references.

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2481 matching lines @@
   CHECK(g2s1->Set(0, g1s1));
 
   {
     Persistent<Value> g1_objects[] = { g1s1, g1s2 };
     Persistent<Value> g1_children[] = { g1c1 };
     Persistent<Value> g2_objects[] = { g2s1, g2s2 };
     Persistent<Value> g2_children[] = { g2c1 };
     V8::AddObjectGroup(g1_objects, 2);
     V8::AddImplicitReferences(g1s1, g1_children, 1);
     V8::AddObjectGroup(g2_objects, 2);
-    V8::AddImplicitReferences(g2s2, g2_children, 1);
+    V8::AddImplicitReferences(g2s1, g2_children, 1);
   }
   // Do a single full GC, ensure incremental marking is stopped.
   HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All object should be alive.
   CHECK_EQ(0, counter.NumberOfWeakCalls());
 
   // Weaken the root.
   root.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
   // But make children strong roots---all the objects (except for children)
   // should be collectable now.
   g1c1.ClearWeak(iso);
   g2c1.ClearWeak(iso);
 
   // Groups are deleted, rebuild groups.
   {
     Persistent<Value> g1_objects[] = { g1s1, g1s2 };
     Persistent<Value> g1_children[] = { g1c1 };
     Persistent<Value> g2_objects[] = { g2s1, g2s2 };
     Persistent<Value> g2_children[] = { g2c1 };
     V8::AddObjectGroup(g1_objects, 2);
     V8::AddImplicitReferences(g1s1, g1_children, 1);
     V8::AddObjectGroup(g2_objects, 2);
-    V8::AddImplicitReferences(g2s2, g2_children, 1);
+    V8::AddImplicitReferences(g2s1, g2_children, 1);
   }
 
   HEAP->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All objects should be gone. 5 global handles in total.
   CHECK_EQ(5, counter.NumberOfWeakCalls());
 
   // And now make children weak again and collect them.
   g1c1.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
   g2c1.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
@@ skipping 34 matching lines @@
     g2c1.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
   }
 
   Persistent<Object> root = Persistent<Object>::New(iso, g1s1);  // make a root.
 
   // Connect group 1 and 2, make a cycle.
   CHECK(g1s2->Set(0, g2s2));
   CHECK(g2s1->Set(0, g1s1));
 
   {
-    Persistent<Value> g1_children[] = { g1c1 };
-    Persistent<Value> g2_children[] = { g2c1 };
-    V8::SetObjectGroupId(iso, g1s1, UniqueId(1));
-    V8::SetObjectGroupId(iso, g1s2, UniqueId(1));
-    V8::AddImplicitReferences(g1s1, g1_children, 1);
-    V8::SetObjectGroupId(iso, g2s1, UniqueId(2));
-    V8::SetObjectGroupId(iso, g2s2, UniqueId(2));
-    V8::AddImplicitReferences(g2s2, g2_children, 1);
+    UniqueId id1(reinterpret_cast<intptr_t>(*g1s1));
+    UniqueId id2(reinterpret_cast<intptr_t>(*g2s2));
+    V8::SetObjectGroupId(iso, g1s1, id1);
+    V8::SetObjectGroupId(iso, g1s2, id1);
+    V8::SetObjectGroupRepresentative(iso, id1, g1s1);
+    V8::AddImplicitReference(iso, id1, g1c1);
+    V8::SetObjectGroupId(iso, g2s1, id2);
+    V8::SetObjectGroupId(iso, g2s2, id2);
+    V8::SetObjectGroupRepresentative(iso, id2, g2s1);
+    V8::AddImplicitReference(iso, id2, g2c1);
   }
   // Do a single full GC, ensure incremental marking is stopped.
   v8::internal::Heap* heap = reinterpret_cast<v8::internal::Isolate*>(
       iso)->heap();
   heap->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All object should be alive.
   CHECK_EQ(0, counter.NumberOfWeakCalls());
 
   // Weaken the root.
   root.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
   // But make children strong roots---all the objects (except for children)
   // should be collectable now.
   g1c1.ClearWeak(iso);
   g2c1.ClearWeak(iso);
 
   // Groups are deleted, rebuild groups.
   {
-    Persistent<Value> g1_children[] = { g1c1 };
-    Persistent<Value> g2_children[] = { g2c1 };
-    V8::SetObjectGroupId(iso, g1s1, UniqueId(1));
-    V8::SetObjectGroupId(iso, g1s2, UniqueId(1));
-    V8::AddImplicitReferences(g1s1, g1_children, 1);
-    V8::SetObjectGroupId(iso, g2s1, UniqueId(2));
-    V8::SetObjectGroupId(iso, g2s2, UniqueId(2));
-    V8::AddImplicitReferences(g2s2, g2_children, 1);
+    UniqueId id1(reinterpret_cast<intptr_t>(*g1s1));
+    UniqueId id2(reinterpret_cast<intptr_t>(*g2s2));
+    V8::SetObjectGroupId(iso, g1s1, id1);
+    V8::SetObjectGroupId(iso, g1s2, id1);
+    V8::SetObjectGroupRepresentative(iso, id1, g1s1);
+    V8::AddImplicitReference(iso, id1, g1c1);
+    V8::SetObjectGroupId(iso, g2s1, id2);
+    V8::SetObjectGroupId(iso, g2s2, id2);
+    V8::SetObjectGroupRepresentative(iso, id2, g2s1);
+    V8::AddImplicitReference(iso, id2, g2c1);
   }
 
   heap->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All objects should be gone. 5 global handles in total.
   CHECK_EQ(5, counter.NumberOfWeakCalls());
 
   // And now make children weak again and collect them.
   g1c1.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
   g2c1.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
@@ skipping 155 matching lines @@
     CHECK(g4s1.IsWeak(iso));
     CHECK(g4s2.IsWeak(iso));
   }
 
   Persistent<Object> root = Persistent<Object>::New(iso, g1s1);  // make a root.
 
   // Connect groups.  We're building the following cycle:
   // G1: { g1s1, g2s1 }, g1s1 implicitly references g2s1, ditto for other
   // groups.
   {
-    Persistent<Value> g1_children[] = { g2s1 };
-    Persistent<Value> g2_children[] = { g3s1 };
-    Persistent<Value> g3_children[] = { g4s1 };
-    Persistent<Value> g4_children[] = { g1s1 };
-    V8::SetObjectGroupId(iso, g1s1, UniqueId(1));
-    V8::SetObjectGroupId(iso, g1s2, UniqueId(1));
-    V8::AddImplicitReferences(g1s1, g1_children, 1);
-    V8::SetObjectGroupId(iso, g2s1, UniqueId(2));
-    V8::SetObjectGroupId(iso, g2s2, UniqueId(2));
-    V8::AddImplicitReferences(g2s1, g2_children, 1);
-    V8::SetObjectGroupId(iso, g3s1, UniqueId(3));
-    V8::SetObjectGroupId(iso, g3s2, UniqueId(3));
-    V8::AddImplicitReferences(g3s1, g3_children, 1);
-    V8::SetObjectGroupId(iso, g4s1, UniqueId(4));
-    V8::SetObjectGroupId(iso, g4s2, UniqueId(4));
-    V8::AddImplicitReferences(g4s1, g4_children, 1);
+    UniqueId id1(reinterpret_cast<intptr_t>(*g1s1));
+    UniqueId id2(reinterpret_cast<intptr_t>(*g2s1));
+    UniqueId id3(reinterpret_cast<intptr_t>(*g3s1));
+    UniqueId id4(reinterpret_cast<intptr_t>(*g4s1));
+    V8::SetObjectGroupId(iso, g1s1, id1);
+    V8::SetObjectGroupId(iso, g1s2, id1);
+    V8::SetObjectGroupRepresentative(iso, id1, g1s1);
+    V8::AddImplicitReference(iso, id1, g2s1);
+    V8::SetObjectGroupId(iso, g2s1, id2);
+    V8::SetObjectGroupId(iso, g2s2, id2);
+    V8::SetObjectGroupRepresentative(iso, id2, g2s1);
+    V8::AddImplicitReference(iso, id2, g3s1);
+    V8::SetObjectGroupId(iso, g3s1, id3);
+    V8::SetObjectGroupId(iso, g3s2, id3);
+    V8::SetObjectGroupRepresentative(iso, id3, g3s1);
+    V8::AddImplicitReference(iso, id3, g4s1);
+    V8::SetObjectGroupId(iso, g4s1, id4);
+    V8::SetObjectGroupId(iso, g4s2, id4);
+    V8::SetObjectGroupRepresentative(iso, id4, g4s1);
+    V8::AddImplicitReference(iso, id4, g1s1);
   }
   // Do a single full GC
   v8::internal::Heap* heap = reinterpret_cast<v8::internal::Isolate*>(
       iso)->heap();
   heap->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All object should be alive.
   CHECK_EQ(0, counter.NumberOfWeakCalls());
 
   // Weaken the root.
   root.MakeWeak(iso, reinterpret_cast<void*>(&counter), &WeakPointerCallback);
 
   // Groups are deleted, rebuild groups.
   {
-    Persistent<Value> g1_children[] = { g2s1 };
-    Persistent<Value> g2_children[] = { g3s1 };
-    Persistent<Value> g3_children[] = { g4s1 };
-    Persistent<Value> g4_children[] = { g1s1 };
-    V8::SetObjectGroupId(iso, g1s1, UniqueId(1));
-    V8::SetObjectGroupId(iso, g1s2, UniqueId(1));
-    V8::AddImplicitReferences(g1s1, g1_children, 1);
-    V8::SetObjectGroupId(iso, g2s1, UniqueId(2));
-    V8::SetObjectGroupId(iso, g2s2, UniqueId(2));
-    V8::AddImplicitReferences(g2s1, g2_children, 1);
-    V8::SetObjectGroupId(iso, g3s1, UniqueId(3));
-    V8::SetObjectGroupId(iso, g3s2, UniqueId(3));
-    V8::AddImplicitReferences(g3s1, g3_children, 1);
-    V8::SetObjectGroupId(iso, g4s1, UniqueId(4));
-    V8::SetObjectGroupId(iso, g4s2, UniqueId(4));
-    V8::AddImplicitReferences(g4s1, g4_children, 1);
+    UniqueId id1(reinterpret_cast<intptr_t>(*g1s1));
+    UniqueId id2(reinterpret_cast<intptr_t>(*g2s1));
+    UniqueId id3(reinterpret_cast<intptr_t>(*g3s1));
+    UniqueId id4(reinterpret_cast<intptr_t>(*g4s1));
+    V8::SetObjectGroupId(iso, g1s1, id1);
+    V8::SetObjectGroupId(iso, g1s2, id1);
+    V8::SetObjectGroupRepresentative(iso, id1, g1s1);
+    V8::AddImplicitReference(iso, id1, g2s1);
+    V8::SetObjectGroupId(iso, g2s1, id2);
+    V8::SetObjectGroupId(iso, g2s2, id2);
+    V8::SetObjectGroupRepresentative(iso, id2, g2s1);
+    V8::AddImplicitReference(iso, id2, g3s1);
+    V8::SetObjectGroupId(iso, g3s1, id3);
+    V8::SetObjectGroupId(iso, g3s2, id3);
+    V8::SetObjectGroupRepresentative(iso, id3, g3s1);
+    V8::AddImplicitReference(iso, id3, g4s1);
+    V8::SetObjectGroupId(iso, g4s1, id4);
+    V8::SetObjectGroupId(iso, g4s2, id4);
+    V8::SetObjectGroupRepresentative(iso, id4, g4s1);
+    V8::AddImplicitReference(iso, id4, g1s1);
   }
 
   heap->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);
 
   // All objects should be gone. 9 global handles in total.
   CHECK_EQ(9, counter.NumberOfWeakCalls());
 }
 
 
 // TODO(mstarzinger): This should be a THREADED_TEST but causes failures
@@ skipping 15852 matching lines @@
   i::Semaphore* sem_;
   volatile int sem_value_;
 };
 
 
 THREADED_TEST(SemaphoreInterruption) {
   ThreadInterruptTest().RunTest();
 }
 
 #endif  // WIN32