New GC related APIs: Implicit references.

src/global-handles.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 24 matching lines @@
 
 namespace v8 {
 namespace internal {
 
 // Structure for tracking global handles.
 // A single list keeps all the allocated global handles.
 // Destroyed handles stay in the list but is added to the free list.
 // At GC the destroyed global handles are removed from the free list
 // and deallocated.
 
+// Data structures for tracking object groups and implicit references.
+
 // An object group is treated like a single JS object: if one of object in
 // the group is alive, all objects in the same group are considered alive.
 // An object group is used to simulate object relationship in a DOM tree.
 
+// An implicit references group consists of two parts: a parent object and a
+// list of children objects.  If the parent is alive, all the children are alive
+// too.
+
 struct ObjectGroupConnection {
   ObjectGroupConnection(UniqueId id, Object** object)
       : id(id), object(object) {}
 
   bool operator==(const ObjectGroupConnection& other) const {
     return id == other.id;
   }
 
   bool operator<(const ObjectGroupConnection& other) const {
     return id < other.id;
@@ skipping 14 matching lines @@
 
   bool operator<(const ObjectGroupRetainerInfo& other) const {
     return id < other.id;
   }
 
   UniqueId id;
   RetainedObjectInfo* info;
 };
 
 
-// An implicit references group consists of two parts: a parent object and
-// a list of children objects.  If the parent is alive, all the children
-// are alive too.
-class ImplicitRefGroup {
- public:
-  static ImplicitRefGroup* New(HeapObject** parent,
-                               Object*** children,
-                               size_t length) {
-    ASSERT(length > 0);
-    ImplicitRefGroup* group = reinterpret_cast<ImplicitRefGroup*>(
-        malloc(OFFSET_OF(ImplicitRefGroup, children_[length])));
-    group->parent_ = parent;
-    group->length_ = length;
-    CopyWords(group->children_, children, static_cast<int>(length));
-    return group;
+struct ObjectGroupRepresentativeObject {

[Michael Starzinger, 2013/04/16 10:42:16]

Let's just call this structure "ObjectGroupRepresentative", the additional
"Object" suffix doesn't provide much additional benefit (especially since these
Objects are called HeapObjects internally).

[marja, 2013/04/16 12:28:37]

Done.

+  ObjectGroupRepresentativeObject(UniqueId id,
+                                  HeapObject** object)
+      : id(id), object(object) {}
+
+  bool operator==(const ObjectGroupRepresentativeObject& other) const {
+    return id == other.id;
   }
 
-  void Dispose() {
-    free(this);
+  bool operator<(const ObjectGroupRepresentativeObject& other) const {
+    return id < other.id;
   }
 
-  HeapObject** parent_;
-  size_t length_;
-  Object** children_[1];  // Variable sized array.
-
- private:
-  void* operator new(size_t size);
-  void operator delete(void* p);
-  ~ImplicitRefGroup();
-  DISALLOW_IMPLICIT_CONSTRUCTORS(ImplicitRefGroup);
+  UniqueId id;
+  HeapObject** object;
 };
 
 
 class GlobalHandles {
  public:
   ~GlobalHandles();
 
   // Creates a new global handle that is alive until Destroy is called.
   Handle<Object> Create(Object* value);
 
@@ skipping 93 matching lines @@
   // All groups are destroyed after a garbage collection.
   void AddObjectGroup(Object*** handles,
                       size_t length,
                       v8::RetainedObjectInfo* info);
 
   // Associates handle with the object group represented by id.
   // Should be only used in GC callback function before a collection.
   // All groups are destroyed after a garbage collection.
   void SetObjectGroupId(Object** handle, UniqueId id);
 
-  void SetRetainedObjectInfo(UniqueId id, RetainedObjectInfo* info = NULL);
+  // Set RetainedObjectInfo for an object group. Should not be called more than
+  // once for a group. Should not be called for a group which contains no
+  // handles.
+  void SetRetainedObjectInfo(UniqueId id, RetainedObjectInfo* info);
+
+  // Sets a representative object for an object group. Should not be called more
+  // than once for a group. Should not be called for a group which contains no
+  // handles.
+  void SetRepresentativeObject(UniqueId id, HeapObject** representative_object);
 
   // Add an implicit references' group.
   // Should be only used in GC callback function before a collection.
   // All groups are destroyed after a mark-compact collection.
   void AddImplicitReferences(HeapObject** parent,
                              Object*** children,
                              size_t length);
 
+  // Adds an implicit reference from a group (representative object of that
+  // group) to an object. Should be only used in GC callback function before a
+  // collection. All implicit references are destroyed after a mark-compact
+  // collection.
+  void AddImplicitReference(UniqueId id, Object** child);
+
   List<ObjectGroupConnection>* object_groups() {
     return &object_groups_;
   }
 
   List<ObjectGroupRetainerInfo>* retainer_infos() {
     return &retainer_infos_;
   }
 
-  // Returns the implicit references' groups.
-  List<ImplicitRefGroup*>* implicit_ref_groups() {
+  List<ObjectGroupConnection>* implicit_ref_groups() {
     return &implicit_ref_groups_;
   }
 
+  List<ObjectGroupRepresentativeObject>* representative_objects() {
+    return &representative_objects_;
+  }
+
   // Remove bags, this should only happen after GC.
   void RemoveObjectGroups();
   void RemoveImplicitRefGroups();
 
   // Tear down the global handle structure.
   void TearDown();
 
   Isolate* isolate() { return isolate_; }
 
 #ifdef DEBUG
@@ skipping 22 matching lines @@
 
   // Free list of nodes.
   Node* first_free_;
 
   // Contains all nodes holding new space objects. Note: when the list
   // is accessed, some of the objects may have been promoted already.
   List<Node*> new_space_nodes_;
 
   int post_gc_processing_count_;
 
+  // Object groups.
   List<ObjectGroupConnection> object_groups_;
   List<ObjectGroupRetainerInfo> retainer_infos_;
-  List<ImplicitRefGroup*> implicit_ref_groups_;
+  List<ObjectGroupRepresentativeObject> representative_objects_;
+
+  // Implicit references.
+  List<ObjectGroupConnection> implicit_ref_groups_;
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(GlobalHandles);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_GLOBAL_HANDLES_H_