Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1417483018: include what you use: errno.h and string.h in content/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
kinuko
CC:
chromium-reviews, asanka, posciak+watch_chromium.org, jam, rickyz+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h and string.h in content/ Adding some missing errno.h includes for errno and string.h for strerror in content/ Committed: https://crrev.com/720163fc735ca812ef0aa2d7ca46dc0a5d407257 Cr-Commit-Position: refs/heads/master@{#359110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M content/browser/download/base_file_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/generic_v4l2_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/v4l2_image_processor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/v4l2_jpeg_decode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@kinuko: here's a small include-what-you-use fix.
5 years, 1 month ago (2015-11-06 23:15:08 UTC) #2
kinuko
lgtm.
5 years, 1 month ago (2015-11-11 08:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417483018/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417483018/1
5 years, 1 month ago (2015-11-11 15:37:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 17:42:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:58:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/720163fc735ca812ef0aa2d7ca46dc0a5d407257
Cr-Commit-Position: refs/heads/master@{#359110}

Powered by Google App Engine
This is Rietveld 408576698