Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1417483004: Remove duplicate core/include/thirdparties headers. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove duplicate core/include/thirdparties headers. These are unused in favor of the ones under the top-level third_party/ directory. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ad0f4d9b371c1862a78046c2e3dea5d515043070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4627 lines) Patch
D core/include/thirdparties/libjpeg/jconfig.h View 1 chunk +0 lines, -51 lines 0 comments Download
D core/include/thirdparties/libjpeg/jerror.h View 1 chunk +0 lines, -291 lines 0 comments Download
D core/include/thirdparties/libjpeg/jmorecfg.h View 1 chunk +0 lines, -376 lines 0 comments Download
D core/include/thirdparties/libjpeg/jpegint.h View 1 chunk +0 lines, -392 lines 0 comments Download
D core/include/thirdparties/libjpeg/jpeglib.h View 1 chunk +0 lines, -1165 lines 0 comments Download
D core/include/thirdparties/zlib/zconf.h View 1 chunk +0 lines, -519 lines 0 comments Download
D core/include/thirdparties/zlib/zlib.h View 1 chunk +0 lines, -1833 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, quick review.
5 years, 2 months ago (2015-10-19 16:23:33 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-19 18:52:58 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-19 21:45:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad0f4d9b371c1862a78046c2e3dea5d515043070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698