Improves the representation of values in Mojom.

Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better understanding obtained by working on the Go version of the parser. The main change is that we now have value keys for enum values as well as user-defined constants. Additionally some terminology was modified. We were using the word "constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Simplify representation of enum values.

R=azani@chromium.org, azani

Committed: https://chromium.googlesource.com/external/mojo/+/973941c0654a582fad653bc627ee5bd57ecd4c16

[rudominer, 2015-10-19 16:26:39]

Description was changed from

==========
Fixes the representation of values in Mojom.

This CL fixes the representation of values in Mojom based on a better
understanding obtained from working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Replace |ConstantOccurrence| with |Value|.

BUG=
==========

to

==========
Improves the representation of values in Mojom.

This CL fixes the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Replace |ConstantOccurrence| with |Value|.

BUG=
==========

[rudominer, 2015-10-19 16:35:26]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL fixes the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Replace |ConstantOccurrence| with |Value|.

BUG=
==========

to

==========
Improves the representation of values in Mojom.

This CL fixes the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified. We were using the word "constant" in
places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

[rudominer, 2015-10-19 16:35:43]

Patchset #1 (id:1) has been deleted

[rudominer, 2015-10-19 16:36:09]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL fixes the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified. We were using the word "constant" in
places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

to

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified. We were using the word "constant" in
places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

[rudominer, 2015-10-19 16:36:42]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as constants.
Additionally some terminology was modified. We were using the word "constant" in
places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

to

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

[rudominer, 2015-10-19 16:39:18]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2015-10-19 16:39:32]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

BUG=
==========

to

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

R=azani
==========

[rudominer, 2015-10-19 16:41:29]

Alex Zani: ptal.

Alex Fandrianto: I don't think this change should affect your work but please
take a look to make sure.

[alexfandrianto, 2015-10-19 18:03:46]

On 2015/10/19 16:41:29, rudominer wrote:
> Alex Zani: ptal.
> 
> Alex Fandrianto: I don't think this change should affect your work but please
> take a look to make sure.

I'll need to update my enum definitions in the template files. Thanks for the
heads up.

[rudominer, 2015-10-19 19:35:19]

Patchset #2 (id:40001) has been deleted

[rudominer, 2015-10-19 19:40:22]

Patchset two contains an update to the file comments that reflects the
following:
(1) We describe values in addition to types.
(2) We remove all mention of MojomDescriptor and instead refer to what we call
the *owning context.*
(3) We de-emphasize the fact that types and values may be not-fully-resolved
because there is currently no known use case for the unresolved case.
(4) We removed the long explanation for why the indirection of type_keys is
necessary because the clarity it adds is not worth the real estate it consumes.

[rudominer, 2015-10-19 20:52:29]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Introduce |ConcreteValue|

- Simplify representation of enum values.

R=azani
==========

to

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |ConcreteValue|  and |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Simplify representation of enum values.

R=azani
==========

[rudominer, 2015-10-20 05:24:04]

Description was changed from

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |ConcreteValue|  and |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Simplify representation of enum values.

R=azani
==========

to

==========
Improves the representation of values in Mojom.

This CL updates the representation of values in Mojom based on a better
understanding obtained by working on the Go version of the parser. The main
change is that we now have value keys for enum values as well as user-defined
constants. Additionally some terminology was modified. We were using the word
"constant" in places
where the word "value" makes more sense.

- Replace  map<string, DeclaredConstant> resolved_constants;
  with     map<string, UserDefinedValue> resolved_values;
  in MojomFileGraph.

- Add support for the "default" keyword as the default value of a struct field.

- Replace |ConstantOccurrence| with |Value|.

- Replace |ConstantValue| with |LiteralValue|.

- Replace |ConstantReference| with |UserValueReference|.

- Simplify representation of enum values.

R=azani
==========

[rudominer, 2015-10-20 05:54:25]

azani: I fixed up mojom_translator. ptal.

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py (left):

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:353: const:
{mojom_types_mojom.ConstantValue} to be evaluated.
This was incorrect in the existing code. The argument was actually a
ConstantOccurrence not a ConstantValue. Now it is a Value which is the new
version of ConstantOccurrence.

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py
(right):

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:176:
struct_field.default = 'default' #TODO(azani) Is this right?
How do we represent the 'default' keyword in a mojom.module?

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:238:
#TODO(azani) What is the difference between value and numeric_value?
What is the difference between value and numeric_value?

[azani, 2015-10-20 21:54:58]

lgtm

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py (left):

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:353: const:
{mojom_types_mojom.ConstantValue} to be evaluated.
On 2015/10/20 05:54:25, rudominer wrote:
> This was incorrect in the existing code. The argument was actually a
> ConstantOccurrence not a ConstantValue. Now it is a Value which is the new
> version of ConstantOccurrence.

Acknowledged.

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py
(right):

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:176:
struct_field.default = 'default' #TODO(azani) Is this right?
On 2015/10/20 05:54:25, rudominer wrote:
> How do we represent the 'default' keyword in a mojom.module?

As the string "default". Yes this is right.

https://codereview.chromium.org/1417473002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:238:
#TODO(azani) What is the difference between value and numeric_value?
On 2015/10/20 05:54:25, rudominer wrote:
> What is the difference between value and numeric_value?

In the data.py module, value is not necessarily resolved.

[rudominer, 2015-10-20 22:06:59]

Committed patchset #4 (id:100001) manually as
973941c0654a582fad653bc627ee5bd57ecd4c16 (presubmit successful).

[azani, 2015-10-20 23:47:15]

On 2015/10/20 22:06:59, rudominer wrote:
> Committed patchset #4 (id:100001) manually as
> 973941c0654a582fad653bc627ee5bd57ecd4c16 (presubmit successful).

Hey Mitch,

It looks like mojom_translator_unittest is broken after this CL got checked in.