Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1417463004: Revert of [es6] Fix scoping for default parameters in arrow functions (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg, wingo
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Fix scoping for default parameters in arrow functions (patchset #5 id:80001 of https://codereview.chromium.org/1405313002/ ) Reason for revert: Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/2407/steps/Check/logs/regress-4395 Original issue's description: > [es6] Fix scoping for default parameters in arrow functions > > When eagerly parsing arrow functions, expressions in default > parameter initializers are parsed in the enclosing scope, > rather than in the function's scope (since that scope does not > yet exist). This leads to VariableProxies being added to the > wrong scope, and scope chains for FunctionLiterals being incorrect. > > This patch addresses these problems by adding a subclass of > AstExpressionVisitor that moves VariableProxies to the proper > scope and fixes up scope chains of FunctionLiterals. > > More work likely still needs to be done to make this work completely, > but it's very close to correct. > > BUG=v8:4395 > LOG=y > > Committed: https://crrev.com/cf72aad39e51de9b7074ea039377c1812f4a2c6b > Cr-Commit-Position: refs/heads/master@{#31402} TBR=rossberg@chromium.org,caitpotter88@gmail.com,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4395 Committed: https://crrev.com/e41614a058426fb6102e4ab2dd4f98997f00c0fc Cr-Commit-Position: refs/heads/master@{#31404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -277 lines) Patch
M BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M src/ast.h View 1 chunk +26 lines, -30 lines 0 comments Download
M src/ast-expression-visitor.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ast-expression-visitor.cc View 3 chunks +7 lines, -33 lines 0 comments Download
D src/parameter-initializer-rewriter.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/parameter-initializer-rewriter.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/pattern-rewriter.cc View 2 chunks +1 line, -10 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scopes.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/scopes.cc View 1 chunk +4 lines, -5 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4395.js View 1 chunk +0 lines, -69 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [es6] Fix scoping for default parameters in arrow functions
5 years, 2 months ago (2015-10-20 10:35:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417463004/1
5 years, 2 months ago (2015-10-20 10:36:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 10:36:24 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 10:36:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e41614a058426fb6102e4ab2dd4f98997f00c0fc
Cr-Commit-Position: refs/heads/master@{#31404}

Powered by Google App Engine
This is Rietveld 408576698