Issue 1417443002: Use an even better random number generation scheme in the prune test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417443002: Use an even better random number generation scheme in the prune test (Closed)

Created:
5 years, 2 months ago by Mark Mentovai

Modified:
5 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Use an even better random number generation scheme in the prune test base::RandInt(0, max - 1) has a uniform distribution. base::RandUint64() % max does not. TEST=crashpad_client_test PruneCrashReports.PruneOrder R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/07dbc3259c568fc08c868a7e14502ce617d469d9

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	client/prune_crash_reports_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 2 months ago (2015-10-19 15:44:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
07dbc3259c568fc08c868a7e14502ce617d469d9 (presubmit successful).