runtime/vm/stack_frame_arm64.h - Issue 1417433002: Don't touch x18 on ARM64 - it is globally reserved on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stack_frame_arm64.h

Issue 1417433002: Don't touch x18 on ARM64 - it is globally reserved on iOS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stack_frame_arm64.h

diff --git a/runtime/vm/stack_frame_arm64.h b/runtime/vm/stack_frame_arm64.h

index 6733724c1c285fcfe50317dae4fe16eb0a4c192c..6a5a1dabaccb716fd7ad3f94b58070e520640c40 100644

--- a/runtime/vm/stack_frame_arm64.h

+++ b/runtime/vm/stack_frame_arm64.h

@@ -44,7 +44,7 @@ static const int kCallerSpSlotFromFp = 2;

static const int kSavedAboveReturnAddress = 3; // Saved above return address.

// Entry and exit frame layout.

-static const int kExitLinkSlotFromEntryFp = -22;

+static const int kExitLinkSlotFromEntryFp = -21;

regis 2015/10/19 20:42:55 A comment referring to the preserved registers wou

rmacnak 2015/10/19 21:14:32 Added COMPILE_ASSERTS on the values of kAbiPreserv

} // namespace dart