Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417433002: Don't touch x18 on ARM64 - it is globally reserved on iOS. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
zra, regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't touch x18 on ARM64 - it is globally reserved on iOS. Move SP on ARM64 to x19. Use a mask instead of a range for determining the globally blocked registers. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/91bc8005fe28a4d613c3c9d26f03fd6ae08b83aa

Patch Set 1 #

Patch Set 2 : mask #

Patch Set 3 : mips compare registers #

Patch Set 4 : lr not reserved on arm, update kExitLinkSlotFromEntryFp on arm64 #

Patch Set 5 : #

Total comments: 5

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -125 lines) Patch
M runtime/vm/constants_arm.h View 1 2 3 4 5 3 chunks +20 lines, -16 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 2 3 4 5 5 chunks +25 lines, -19 lines 0 comments Download
M runtime/vm/constants_ia32.h View 1 4 chunks +14 lines, -3 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 2 5 chunks +26 lines, -16 lines 0 comments Download
M runtime/vm/constants_x64.h View 1 2 3 4 5 4 chunks +16 lines, -3 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 1 1 chunk +4 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 4 chunks +5 lines, -29 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 3 4 5 2 chunks +19 lines, -18 lines 0 comments Download
M runtime/vm/stack_frame_arm.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/stack_frame_arm64.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/stack_frame_mips.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc#newcode1654 runtime/vm/simulator_arm64.cc:1654: set_register(instr, R2, icount_); Maybe these should all be with ...
5 years, 2 months ago (2015-10-19 20:11:04 UTC) #3
regis
lgtm https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc#newcode1654 runtime/vm/simulator_arm64.cc:1654: set_register(instr, R2, icount_); On 2015/10/19 20:11:04, rmacnak wrote: ...
5 years, 2 months ago (2015-10-19 20:42:56 UTC) #4
rmacnak
https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/1417433002/diff/80001/runtime/vm/simulator_arm64.cc#newcode1654 runtime/vm/simulator_arm64.cc:1654: set_register(instr, R2, icount_); On 2015/10/19 20:42:55, regis wrote: > ...
5 years, 2 months ago (2015-10-19 21:14:32 UTC) #5
rmacnak
5 years, 2 months ago (2015-10-19 21:17:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
91bc8005fe28a4d613c3c9d26f03fd6ae08b83aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698