extensions/common/permissions/permissions_data_unittest.cc - Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/permissions/permissions_data_unittest.cc

===================================================================

--- extensions/common/permissions/permissions_data_unittest.cc (revision 247036)

+++ extensions/common/permissions/permissions_data_unittest.cc (working copy)

@@ -131,9 +131,11 @@

Manifest::INTERNAL, Extension::NO_FLAGS,

&error);

EXPECT_TRUE(extension.get() == NULL);

- ASSERT_EQ(ErrorUtils::FormatErrorMessage(

- manifest_errors::kInvalidPermission, "socket"),

- error);

+ std::string expected_error_msg_header = ErrorUtils::FormatErrorMessage(

+ manifest_errors::kInvalidPermissionWithDetail,

+ "socket",

+ "NULL or empty permission list");

+ EXPECT_EQ(expected_error_msg_header, error);

extension = LoadManifest("socket_permissions", "socket2.json");

EXPECT_TRUE(CheckSocketPermission(extension,

« no previous file with comments | « extensions/common/permissions/api_permission_set_unittest.cc ('k') | no next file » | no next file with comments »