Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: extensions/common/permissions/api_permission.h

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_constants.cc ('k') | extensions/common/permissions/api_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/api_permission.h
===================================================================
--- extensions/common/permissions/api_permission.h (revision 247036)
+++ extensions/common/permissions/api_permission.h (working copy)
@@ -204,8 +204,9 @@
// Returns true if |rhs| is equal to this.
virtual bool Equal(const APIPermission* rhs) const = 0;
- // Parses the APIPermission from |value|. Returns false if error happens.
- virtual bool FromValue(const base::Value* value) = 0;
+ // Parses the APIPermission from |value|. Returns false if an error happens
+ // and optionally set |error| if |error| is not NULL.
+ virtual bool FromValue(const base::Value* value, std::string* error) = 0;
// Stores this into a new created |value|.
virtual scoped_ptr<base::Value> ToValue() const = 0;
« no previous file with comments | « extensions/common/manifest_constants.cc ('k') | extensions/common/permissions/api_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698