build/toolchain/mac/BUILD.gn - Issue 1417423007: Put GN object files in subdir based on the label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 1417423007: Put GN object files in subdir based on the label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/mac/BUILD.gn

diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn

index fea76e10b5dea8549a318b4f847a5d08f1f57fb8..a64387f718a2717c0abfabe0e0cd444ded586aa5 100644

--- a/build/toolchain/mac/BUILD.gn

+++ b/build/toolchain/mac/BUILD.gn

@@ -52,9 +52,7 @@ template("mac_toolchain") {

# Object files go in this directory. Use label_name instead of

# target_output_name since labels will generally have no spaces and will be

# unique in the directory.

- # TODO(brettw) enable the label_name variant when binary support is rolled in to GN.

- #object_subdir = "{{target_out_dir}}/{{label_name}}"

- object_subdir = "{{target_out_dir}}/{{target_output_name}}"

+ object_subdir = "{{target_out_dir}}/{{label_name}}"

tool("cc") {

depfile = "{{output}}.d"

« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »