Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1417423007: Put GN object files in subdir based on the label. (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put GN object files in subdir based on the label. Previously the subdir was based on the output name. These are usually the same but might be different if output_name is overridden, and for libraries on Linux that have a "lib" prefix. The label name is more unique better matches what one would expect (especiall for the "lib" prefix case). Most importantly, the output name might have spaces which confuses Mac. BUG=546894 Committed: https://crrev.com/ea6d9154695bb4ce09ae88006d572e0c0e472b23 Cr-Commit-Position: refs/heads/master@{#358925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M build/toolchain/gcc_toolchain.gni View 3 chunks +6 lines, -3 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
Blocked on GN roll: https://codereview.chromium.org/1434783002/
5 years, 1 month ago (2015-11-10 18:44:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417423007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417423007/1
5 years, 1 month ago (2015-11-10 20:34:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 21:11:46 UTC) #6
Bons
lgtm
5 years, 1 month ago (2015-11-10 21:57:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417423007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417423007/1
5 years, 1 month ago (2015-11-10 21:58:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 22:11:20 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 22:11:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea6d9154695bb4ce09ae88006d572e0c0e472b23
Cr-Commit-Position: refs/heads/master@{#358925}

Powered by Google App Engine
This is Rietveld 408576698