Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417423003: chrome: Rename WrenchMenuModel to AppMenuModel. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tfarina, Ben Goodger (Google), Greg Billock, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: Rename WrenchMenuModel to AppMenuModel. It is not a wrench button for a long time now, the new icon is a sideways ellipsis called browser_tools. BUG=None R=pkasting@chromium.org TBR=thestig@chromium.org Committed: https://crrev.com/a10d4315f714e872cf40ca662887fccec7047b3c Cr-Commit-Position: refs/heads/master@{#356105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1417 lines) Patch
M chrome/browser/profiles/profile_window_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 8 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 4 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/toolbar/app_menu_model.h View 5 chunks +17 lines, -16 lines 0 comments Download
A + chrome/browser/ui/toolbar/app_menu_model.cc View 21 chunks +41 lines, -44 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +0 lines, -1036 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 6 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
5 years, 1 month ago (2015-10-26 14:50:43 UTC) #1
Peter Kasting
LGTM
5 years, 1 month ago (2015-10-26 19:22:47 UTC) #2
tfarina
TBRing Lei for the rest of chrome/ changes outside of chrome/browser/ui/.
5 years, 1 month ago (2015-10-26 20:03:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417423003/1
5 years, 1 month ago (2015-10-26 20:06:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 20:11:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a10d4315f714e872cf40ca662887fccec7047b3c Cr-Commit-Position: refs/heads/master@{#356105}
5 years, 1 month ago (2015-10-26 20:12:34 UTC) #8
Lei Zhang
5 years, 1 month ago (2015-10-26 20:34:12 UTC) #9
Message was sent while issue was closed. 
On 2015/10/26 20:03:54, tfarina wrote:
> TBRing Lei for the rest of chrome/ changes outside of chrome/browser/ui/.

lgtm

Powered by Google App Engine
This is Rietveld 408576698