win: Implement c16lcpy without base:c16*

win: Implement c16lcpy without base:c16*

Chromium base doesn't have base::c16len, c16memcpy, etc. when
WCHAR_T_IS_UTF16, so implement c16lcpy without using those.

R=mark@chromium.org
BUG=crashpad:1, chromium:546288
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4b8b42be6cca9a5aa1103472de2c9da880e2512a

[Mark Mentovai, 2015-10-23 20:24:32]

LGTM

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc
File util/stdlib/strlcpy.cc (right):

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc#newc...
util/stdlib/strlcpy.cc:1: // Copyright 2014 The Crashpad Authors. All rights
reserved.
The CL description says that c16len() and c16memcpy() aren’t available in
Chrome, but that’s only true for WCHAR_T_IS_UTF16. Can you fix the description
to be more accurate? I read the description, trusted what it said, and then saw
that these two functions were still being used by the WCHAR_T_IS_UTF32 case and
thought: “?”

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc#newc...
util/stdlib/strlcpy.cc:30: StringCchCopyW(destination, length, source);
CHECK that the return value is either of the two acceptable HRESULTs.

[scottmg, 2015-10-23 20:30:49]

Description was changed from

==========
win: Implement c16lcpy without base:c16*

Chromium base doesn't have base::c16len, c16memcpy, etc. so implement
c16lcpy without using those.

R=mark@chromium.org
BUG=crashpad:1, chromium:546288
==========

to

==========
win: Implement c16lcpy without base:c16*

Chromium base doesn't have base::c16len, c16memcpy, etc. when
WCHAR_T_IS_UTF16, so implement c16lcpy without using those.

R=mark@chromium.org
BUG=crashpad:1, chromium:546288
==========

[scottmg, 2015-10-23 20:32:40]

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc
File util/stdlib/strlcpy.cc (right):

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc#newc...
util/stdlib/strlcpy.cc:1: // Copyright 2014 The Crashpad Authors. All rights
reserved.
On 2015/10/23 20:24:32, Mark Mentovai wrote:
> The CL description says that c16len() and c16memcpy() aren’t available in
> Chrome, but that’s only true for WCHAR_T_IS_UTF16. Can you fix the description
> to be more accurate? I read the description, trusted what it said, and then
saw
> that these two functions were still being used by the WCHAR_T_IS_UTF32 case
and
> thought: “?”

Done.

https://codereview.chromium.org/1417403004/diff/1/util/stdlib/strlcpy.cc#newc...
util/stdlib/strlcpy.cc:30: StringCchCopyW(destination, length, source);
On 2015/10/23 20:24:32, Mark Mentovai wrote:
> CHECK that the return value is either of the two acceptable HRESULTs.

Done.

[scottmg, 2015-10-23 20:38:51]

Committed patchset #2 (id:20001) manually as
4b8b42be6cca9a5aa1103472de2c9da880e2512a (presubmit successful).