Added non observable side effects scope and removed unnecessary calls to AddSimulate.

Added non observable side effects scope and removed unnecessary calls to AddSimulate.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14232

[danno, 2013-04-11 12:55:51]

lgtm with comments

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h#newcode871
src/hydrogen.h:871: in_no_side_effects_scope_(0) {}
no_side_effects_scope_count_?

[Hannes Payer (out of office), 2013-04-11 13:00:02]

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h#newcode871
src/hydrogen.h:871: in_no_side_effects_scope_(0) {}
On 2013/04/11 12:55:51, danno wrote:
> no_side_effects_scope_count_?

Done.

[mvstanton, 2013-04-11 13:02:38]

LGTM with a comment. Thanks this is really helpful stuff too.

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.cc#newcode900
src/hydrogen.cc:900: ASSERT(in_no_side_effects_scope_ == 0);
this is a great assert.

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h#newcode902
src/hydrogen.h:902: in_no_side_effects_scope_--;
I would add ASSERT(in_no_side_effects_scope >= 0); since this method is public
and somebody could start calling it without the nice scope class below.

[Hannes Payer (out of office), 2013-04-11 13:07:48]

Committed patchset #2 manually as r14232 (presubmit successful).