Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1417373005: Fix shared library support in glibc python build (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years, 1 month ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fix shared library support in glibc python build R=bradnelson Committed: https://chromium.googlesource.com/external/naclports/+/0e155040ba2f4d39038e93a35243d5d7348c51b1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M build_tools/common.sh View 2 chunks +7 lines, -6 lines 0 comments Download
M ports/python/build.sh View 2 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417373005/1
5 years, 1 month ago (2015-10-27 03:23:58 UTC) #2
Sam Clegg
5 years, 1 month ago (2015-10-27 03:24:01 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: naclports-linux-glibc-1 on tryserver.nacl (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/builds/1379)
5 years, 1 month ago (2015-10-27 09:24:21 UTC) #5
bradnelson
lgtm https://codereview.chromium.org/1417373005/diff/1/ports/python/build.sh File ports/python/build.sh (right): https://codereview.chromium.org/1417373005/diff/1/ports/python/build.sh#newcode105 ports/python/build.sh:105: lib/libreadline.so lib/libncurses.so.5 lib/libbz2.so.1.0 \ Just so I'm clear, ...
5 years, 1 month ago (2015-10-27 17:34:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417373005/1
5 years, 1 month ago (2015-10-27 17:34:29 UTC) #8
Sam Clegg
On 2015/10/27 17:34:23, bradnelson wrote: > lgtm > > https://codereview.chromium.org/1417373005/diff/1/ports/python/build.sh > File ports/python/build.sh (right): > ...
5 years, 1 month ago (2015-10-27 17:45:52 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 20:12:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/naclports/+/0e155040ba2f4d39038e93...

Powered by Google App Engine
This is Rietveld 408576698