Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 1417373004: Add a ResetTimer class. (Closed)

Created:
3 years, 7 months ago by nweiz
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a RestartableTimer class. This is useful for heartbeat-style timeouts where a timeout is reset when certain actions occur. R=lrn@google.com Committed: https://github.com/dart-lang/async/commit/d23c21e14f6e14cee5d02564d6a096f9ebc5d36e

Patch Set 1 #

Total comments: 24

Patch Set 2 : Code review changes #

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -1 line) Patch
M CHANGELOG.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M lib/async.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A lib/src/restartable_timer.dart View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
A test/restartable_timer_test.dart View 1 2 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
nweiz
3 years, 7 months ago (2015-10-27 02:55:52 UTC) #1
Lasse Reichstein Nielsen
LGTM https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart File lib/src/reset_timer.dart (right): https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart#newcode9 lib/src/reset_timer.dart:9: /// A non-periodic timer that can be reset. ...
3 years, 7 months ago (2015-10-27 09:45:14 UTC) #2
nweiz
Code review changes
3 years, 7 months ago (2015-10-27 21:07:53 UTC) #3
nweiz
Waiting to commit for another round of feedback on naming. https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart File lib/src/reset_timer.dart (right): https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart#newcode9 ...
3 years, 7 months ago (2015-10-27 21:08:12 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart File lib/src/reset_timer.dart (right): https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart#newcode9 lib/src/reset_timer.dart:9: /// A non-periodic timer that can be reset. I ...
3 years, 7 months ago (2015-10-28 09:51:03 UTC) #5
nweiz
Code review changes
3 years, 7 months ago (2015-10-28 21:10:38 UTC) #6
nweiz
https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart File lib/src/reset_timer.dart (right): https://codereview.chromium.org/1417373004/diff/1/lib/src/reset_timer.dart#newcode9 lib/src/reset_timer.dart:9: /// A non-periodic timer that can be reset. On ...
3 years, 7 months ago (2015-10-28 21:10:43 UTC) #7
nweiz
3 years, 7 months ago (2015-10-28 21:11:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d23c21e14f6e14cee5d02564d6a096f9ebc5d36e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698