ui/gfx/gpu_memory_buffer.h - Issue 1417363006: ui: Add support for creating GLImage instances from shared memory pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/gpu_memory_buffer.h

Issue 1417363006: ui: Add support for creating GLImage instances from shared memory pools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@usage-rename

Patch Set: windows build fix Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc ('K') | « gpu/command_buffer/service/in_process_command_buffer.cc ('k') | ui/gl/gl_image_shared_memory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/gfx/gpu_memory_buffer.h

diff --git a/ui/gfx/gpu_memory_buffer.h b/ui/gfx/gpu_memory_buffer.h

index 72ff1d26704eeed8cb9e9a4b4bcd68be897b0d5a..f26a966e63e06627d5fab707f00bdfcbe578e919 100644

--- a/ui/gfx/gpu_memory_buffer.h

+++ b/ui/gfx/gpu_memory_buffer.h

@@ -38,6 +38,7 @@ struct GFX_EXPORT GpuMemoryBufferHandle {

GpuMemoryBufferType type;

GpuMemoryBufferId id;

base::SharedMemoryHandle handle;

+ off_t offset;

piman 2015/10/26 16:17:50 I think I would prefer a well-defined-sized type f

reveman 2015/10/26 17:25:34 Makes sense. I changed to uint32_t in latest patch

#if defined(USE_OZONE)

NativePixmapHandle native_pixmap_handle;

#endif