ui: Add support for creating GLImage instances from shared memory pools.

ui: Add support for creating GLImage instances from shared memory pools.

This adds an offset field to the GpuMemoryBufferHandle struct that
allows shared memory backed GLImages to be created from a pool of
shared memory. This is useful when importing buffers as it allows
the clients to manage the memory used for buffers.

BUG=538325
TEST=gl_unittests --gtest_filter=GLImageSharedMemoryPool/GLImageCopyTest/0.CopyTexImage
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9291c758490f36fb7139e2a6a8c341e118037d3a
Cr-Commit-Position: refs/heads/master@{#356212}

[reveman, 2015-10-26 12:28:13]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-10-26 16:17:50]

https://codereview.chromium.org/1417363006/diff/20001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc (right):

https://codereview.chromium.org/1417363006/diff/20001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:171:
DCHECK_EQ(offset_, 0) << "Buffer offset is not supported by Map()";
nit: you could map the entire buffer, but add the offset in memory().

https://codereview.chromium.org/1417363006/diff/20001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/1417363006/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:41: off_t offset;
I think I would prefer a well-defined-sized type for something that goes through
IPC. Case in mind is NaCl, where the bitness may be different between client and
service (we don't expose GMB today, but maybe in the future).

[reveman, 2015-10-26 17:25:34]

ptal

https://codereview.chromium.org/1417363006/diff/20001/content/common/gpu/clie...
File content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc (right):

https://codereview.chromium.org/1417363006/diff/20001/content/common/gpu/clie...
content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc:171:
DCHECK_EQ(offset_, 0) << "Buffer offset is not supported by Map()";
On 2015/10/26 at 16:17:50, piman (slow to review) wrote:
> nit: you could map the entire buffer, but add the offset in memory().

Doing that in latest patch but without the GLImage optimization where we Map
only the region used. Trying to keep it simple for now as we don't have a Map()
use-case for this yet..

https://codereview.chromium.org/1417363006/diff/20001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/1417363006/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:41: off_t offset;
On 2015/10/26 at 16:17:50, piman (slow to review) wrote:
> I think I would prefer a well-defined-sized type for something that goes
through IPC. Case in mind is NaCl, where the bitness may be different between
client and service (we don't expose GMB today, but maybe in the future).

Makes sense. I changed to uint32_t in latest patch for the handle and size_t
everywhere else as that's more consistent with existing code than off_t.

[piman, 2015-10-26 17:39:08]

lgtm

[reveman, 2015-10-26 20:41:54]

reveman@chromium.org changed reviewers:
+ kenrb@chromium.org

[reveman, 2015-10-26 20:41:55]

+kenrb for content/common/child_process_messages.h

[reveman, 2015-10-26 20:42:08]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 20:42:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417363006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417363006/40001

[kenrb, 2015-10-26 20:43:49]

ipc lgtm

[commit-bot: I haz the power, 2015-10-26 21:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 21:01:43]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[reveman, 2015-10-26 21:27:51]

reveman@chromium.org changed reviewers:
+ fsamuel@chromium.org

[reveman, 2015-10-26 21:27:51]

+fsamuel for components/mus/gles2/

[reveman, 2015-10-26 21:28:00]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 21:28:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417363006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417363006/60001

[reveman, 2015-10-26 21:58:45]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 22:00:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417363006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417363006/80001

[Fady Samuel, 2015-10-26 22:23:44]

MUS lgtm

[commit-bot: I haz the power, 2015-10-26 23:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 23:45:17]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[reveman, 2015-10-26 23:59:15]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-10-26 23:59:15]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1417363006/#ps80001
(title: "static_cast<off_t> to make windows build happy")

[commit-bot: I haz the power, 2015-10-26 23:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417363006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417363006/80001

[commit-bot: I haz the power, 2015-10-27 02:39:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-27 02:40:08]

Patchset 5 (id:??) landed as
https://crrev.com/9291c758490f36fb7139e2a6a8c341e118037d3a
Cr-Commit-Position: refs/heads/master@{#356212}