Issue 1417363003: Fixed improper construction of custom elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417363003: Fixed improper construction of custom elements. (Closed)

Created:
5 years, 2 months ago by terry

Modified:
5 years, 2 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed improper construction of custom elements. Was a too aggressive on upgrading a custom element. If a JS object is a custom element never construct using the actual custom class in wrap_jso only allocate the TemplateElement or HtmlElement and let the upgrader or createdCallback do the upgrading. This was causing timing issues with nested custom elements that were data bound. TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/d796048fccea932b074a508505ccea1ab283f354

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -35 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+21 lines, -2 lines	0 comments	Download
M	sdk/lib/html/html_common/conversions_dartium.dart	View	2 chunks	+18 lines, -33 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

terry

Committed patchset #1 (id:1) manually as d796048fccea932b074a508505ccea1ab283f354 (presubmit successful).

5 years, 2 months ago (2015-10-22 23:35:53 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages