Move focus management API from HTMLDocument to Document

Move focus management API from HTMLDocument to Document

Move focus management API from HTMLDocument to Document as per the HTML5
specification:
http://www.whatwg.org/specs/web-apps/current-work/#focus-management

The hasFocus() / activeElement API is now available to both HTML and XML
documents, not only HTML documents.

This change is consistent with the behavior of Firefox 26 and IE 11.

R=tkent, arv
BUG=335788
TEST=fast/dom/Document/xml-document-focus.xml

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165515

[arv (Not doing code reviews), 2014-01-21 19:18:15]

LGTM

Do you want another test that ensures that the document is a Document and not an
HTMLDocument?

[Inactive, 2014-01-21 19:22:28]

On 2014/01/21 19:18:15, arv wrote:
> LGTM
> 
> Do you want another test that ensures that the document is a Document and not
an
> HTMLDocument?

I did not add the check because I think it should really be an XMLDocument, not
a Document (I am working on XMLDocument support).
Then again, I can always add the check and update it later. What do you think?

[arv (Not doing code reviews), 2014-01-21 19:29:24]

I think it would be worth while to add the test now. Once we fix the issue
related to Document we can just update the test.


On Tue, Jan 21, 2014 at 2:22 PM, <ch.dumez@samsung.com> wrote:

> On 2014/01/21 19:18:15, arv wrote:
>
>> LGTM
>>
>
>  Do you want another test that ensures that the document is a Document and
>> not
>>
> an
>
>> HTMLDocument?
>>
>
> I did not add the check because I think it should really be an
> XMLDocument, not
> a Document (I am working on XMLDocument support).
> Then again, I can always add the check and update it later. What do you
> think?
>
> https://codereview.chromium.org/141733006/
>



-- 
erik

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Inactive, 2014-01-21 19:55:52]

On 2014/01/21 19:29:24, arv wrote:
> I think it would be worth while to add the test now. Once we fix the issue
> related to Document we can just update the test.

Fair enough, it's done.

[arv (Not doing code reviews), 2014-01-21 20:13:46]

On 2014/01/21 19:55:52, Chris Dumez wrote:
> On 2014/01/21 19:29:24, arv wrote:
> > I think it would be worth while to add the test now. Once we fix the issue
> > related to Document we can just update the test.
> 
> Fair enough, it's done.

I was thinking we could try it on a non HTMLDocument.

[Inactive, 2014-01-21 20:19:23]

On 2014/01/21 20:13:46, arv wrote:
> On 2014/01/21 19:55:52, Chris Dumez wrote:
> > On 2014/01/21 19:29:24, arv wrote:
> > > I think it would be worth while to add the test now. Once we fix the issue
> > > related to Document we can just update the test.
> > 
> > Fair enough, it's done.
> 
> I was thinking we could try it on a non HTMLDocument.

Maybe I am misunderstanding but the document in my layout test is a
non-HTMLDocument. The issue was that focus management was not available to
non-HTMLDocuments, thus this particular layout test.

[arv (Not doing code reviews), 2014-01-21 20:38:23]

On 2014/01/21 20:19:23, Chris Dumez wrote:
> On 2014/01/21 20:13:46, arv wrote:
> > On 2014/01/21 19:55:52, Chris Dumez wrote:
> > > On 2014/01/21 19:29:24, arv wrote:
> > > > I think it would be worth while to add the test now. Once we fix the
issue
> > > > related to Document we can just update the test.
> > > 
> > > Fair enough, it's done.
> > 
> > I was thinking we could try it on a non HTMLDocument.
> 
> Maybe I am misunderstanding but the document in my layout test is a
> non-HTMLDocument. The issue was that focus management was not available to
> non-HTMLDocuments, thus this particular layout test.

I'm sorry. I misread shouldNotBe as shouldBe :-|

LGTM

[tkent, 2014-01-21 23:50:42]

lgtm

[commit-bot: I haz the power, 2014-01-21 23:50:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/141733006/70001

[commit-bot: I haz the power, 2014-01-22 07:09:53]

Change committed as 165515