Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame
Patch Set: Addressed CR feedback from nasko@. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/mhtml_generation_manager.h
diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h
index 1c0a51eb4ca32ee7caebcc5d282ac39669aa7865..0311f86b72ccfedff22be98d7b9723d8c361e744 100644
--- a/content/browser/download/mhtml_generation_manager.h
+++ b/content/browser/download/mhtml_generation_manager.h
@@ -6,11 +6,14 @@
#define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
#include <map>
+#include <set>
+#include <string>
#include "base/files/file.h"
#include "base/memory/singleton.h"
#include "base/process/process.h"
#include "ipc/ipc_platform_file.h"
+#include "url/gurl.h"
namespace base {
class FilePath;
@@ -18,6 +21,7 @@ class FilePath;
namespace content {
+class RenderFrameHostImpl;
class WebContents;
// The class and all of its members live on the UI thread. Only static methods
@@ -39,8 +43,11 @@ class MHTMLGenerationManager {
// Handler for FrameHostMsg_SerializeAsMHTMLResponse (a notification from the
// renderer that the MHTML generation finished for a single frame).
- void OnSavedFrameAsMHTML(int job_id,
- bool mhtml_generation_in_renderer_succeeded);
+ void OnSerializeAsMHTMLResponse(
+ RenderFrameHostImpl* sender,
Łukasz Anforowicz 2015/12/30 19:47:10 Passing |RenderFrameHostImpl* sender| instead of |
+ int job_id,
+ bool mhtml_generation_in_renderer_succeeded,
+ const std::set<std::string>& digests_of_uris_of_serialized_resources);
private:
friend struct base::DefaultSingletonTraits<MHTMLGenerationManager>;
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/mhtml_generation_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698