chrome/browser/download/save_page_browsertest.cc - Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame

Patch Set: Addressed CR feedback from rdsmith@. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/save_page_browsertest.cc

diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc

index b4293b81eab4e6183ac597c0855398f0561b3de1..949707e8ba1ae87975553e1c2b07e7490bb7579e 100644

--- a/chrome/browser/download/save_page_browsertest.cc

+++ b/chrome/browser/download/save_page_browsertest.cc

@@ -904,10 +904,7 @@ IN_PROC_BROWSER_TEST_F(SavePageSitePerProcessBrowserTest, SaveAsMHTML) {

count++;

pos++;

}

- // TODO(lukasza): Need to dedupe savable resources (i.e. 1.png) across frames.

- // This will be fixed by crrev.com/1417323006.

- // EXPECT_EQ(1, count)

- // << "Verify number of image/png parts in the mhtml output";

+ EXPECT_EQ(1, count) << "Verify number of image/png parts in the mhtml output";

}

// Test suite that verifies that the frame tree "looks" the same before

« no previous file with comments | « no previous file | content/browser/download/mhtml_generation_manager.h » ('j') | content/browser/download/mhtml_generation_manager.cc » ('J')