content/browser/download/mhtml_generation_manager.h - Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1417323006: OOPIFs: Deduplicating MHTML parts across frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-serialization-per-frame

Patch Set: Passing MHTMLPartsGenerationDelegate by pointer. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/mhtml_generation_manager.cc » ('j') | content/browser/download/mhtml_generation_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/mhtml_generation_manager.h

diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h

index 1c0a51eb4ca32ee7caebcc5d282ac39669aa7865..61da5b18cd09a326ef31760aecaf9224bacd2ec3 100644

--- a/content/browser/download/mhtml_generation_manager.h

+++ b/content/browser/download/mhtml_generation_manager.h

@@ -6,11 +6,14 @@

#define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_

#include <map>

+#include <set>

+#include <string>

#include "base/files/file.h"

#include "base/memory/singleton.h"

#include "base/process/process.h"

#include "ipc/ipc_platform_file.h"

+#include "url/gurl.h"

namespace base {

class FilePath;

@@ -39,8 +42,10 @@ class MHTMLGenerationManager {

// Handler for FrameHostMsg_SerializeAsMHTMLResponse (a notification from the

// renderer that the MHTML generation finished for a single frame).

- void OnSavedFrameAsMHTML(int job_id,

- bool mhtml_generation_in_renderer_succeeded);

+ void OnSerializeAsMHTMLResponse(

+ int job_id,

+ bool mhtml_generation_in_renderer_succeeded,

+ const std::set<std::string>& digests_of_uris_of_serialized_resources);

private:

friend struct base::DefaultSingletonTraits<MHTMLGenerationManager>;