Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1417303005: Revert of X87: disable the regress-undefined-nan test case for x87. (Closed)

Created:
5 years, 1 month ago by chunyang.dai
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of X87: disable the regress-undefined-nan test case for x87. (patchset #1 id:1 of https://codereview.chromium.org/1414733004/ ) Reason for revert: because of merge mistake, "regress/" is missed when skipping one test case for X87. "regress/" will be added when relanding it. Original issue's description: > X87: disable the regress-undefined-nan test case for x87. > > The reason is when native_context_specialization flag is ture, X87 turbofan > will hit the known issue that X87 will change a sNaN to qNaN by default. And > then it will fail when bit-comparing the source (sNaN) and the result (qNaN). > > BUG= > > Committed: https://crrev.com/b3c719ebbad6c87afefa33a7d0b3f412b2e304db > Cr-Commit-Position: refs/heads/master@{#31530} TBR=bmeurer@chromium.org,weiliang.lin@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e8ff5181d3fb9da9f8460d969c0130535f86c7b4 Cr-Commit-Position: refs/heads/master@{#31543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
chunyang.dai
Created Revert of X87: disable the regress-undefined-nan test case for x87.
5 years, 1 month ago (2015-10-26 03:43:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417303005/1
5 years, 1 month ago (2015-10-26 03:43:55 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-10-26 03:43:57 UTC) #4
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-26 04:42:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417303005/1
5 years, 1 month ago (2015-10-26 04:42:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 04:42:33 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 04:42:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8ff5181d3fb9da9f8460d969c0130535f86c7b4
Cr-Commit-Position: refs/heads/master@{#31543}

Powered by Google App Engine
This is Rietveld 408576698