dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart - Issue 14173005: Update dart:mirrors to use Symbol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart

Issue 14173005: Update dart:mirrors to use Symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix various issues discovered during own review. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/runtime/lib/symbol_patch.dart ('K') | « dart/sdk/lib/_collection_dev/symbol.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart

diff --git a/dart/editor/tools/plugins/com.google.dart.tools.debug.core_test/data/scripts/test.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart

similarity index 68%

copy from dart/editor/tools/plugins/com.google.dart.tools.debug.core_test/data/scripts/test.dart

copy to dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart

index e67e24b968af7775f7d780650dfb1819df5c754f..30c99adac30193c5c518efe1c4175058eff1d856 100644

--- a/dart/editor/tools/plugins/com.google.dart.tools.debug.core_test/data/scripts/test.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/collection_dev_patch.dart

@@ -2,8 +2,7 @@

// BSD-style license that can be found in the LICENSE file.

-void main() {

- print("1");

- print("2");

- print("3");

+patch class Symbol implements core.Symbol {

+ patch const Symbol(String name)

Søren Gjesse 2013/04/15 14:08:31 Fits one line.

ahe 2013/04/15 14:29:55 I think the style guide recommends putting it on a

+ : this._name = name;

}