src/runtime/runtime-classes.cc - Issue 1417243002: [es6] Partially implement Reflect.setPrototypeOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 1417243002: [es6] Partially implement Reflect.setPrototypeOf. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index 8eee6b808ec3c5df6331d15e11297047f7cac0aa..00ce27325a15a41158b9bae2d367506da75814e1 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -162,9 +162,8 @@ static MaybeHandle<Object> DefineClass(Isolate* isolate, Handle<Object> name,

Object);

if (!constructor_parent.is_null()) {

- RETURN_ON_EXCEPTION(

- isolate, JSObject::SetPrototype(constructor, constructor_parent, false),

- Object);

+ MAYBE_RETURN_NULL(JSObject::SetPrototype(constructor, constructor_parent,

+ false, THROW_ON_ERROR));

}

JSObject::AddProperty(prototype, isolate->factory()->constructor_string(),

« no previous file with comments | « src/runtime/runtime-array.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »