src/api-natives.cc - Issue 1417243002: [es6] Partially implement Reflect.setPrototypeOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-natives.cc

Issue 1417243002: [es6] Partially implement Reflect.setPrototypeOf. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api-natives.cc

diff --git a/src/api-natives.cc b/src/api-natives.cc

index 28d6a498a392241417fb1eca00773a73cd678251..cda22a6af345d62bb1b31dfd3b0d2cf503302514 100644

--- a/src/api-natives.cc

+++ b/src/api-natives.cc

@@ -299,9 +299,9 @@ MaybeHandle<JSFunction> InstantiateFunction(Isolate* isolate,

JSObject::GetProperty(parent_instance,

isolate->factory()->prototype_string()),

JSFunction);

- RETURN_ON_EXCEPTION(

- isolate, JSObject::SetPrototype(prototype, parent_prototype, false),

- JSFunction);

+ MAYBE_RETURN(JSObject::SetPrototype(prototype, parent_prototype, false,

+ THROW_ON_ERROR),

+ MaybeHandle<JSFunction>());

}

auto function = ApiNatives::CreateApiFunction(

« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »