Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417243002: [es6] Partially implement Reflect.setPrototypeOf. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Partially implement Reflect.setPrototypeOf. Proxies are not properly supported yet. R=rossberg BUG=v8:3931 LOG=n Committed: https://crrev.com/2c7787ad847ee1d0fdd752b453adac3648b111a6 Cr-Commit-Position: refs/heads/master@{#31465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -83 lines) Patch
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/api-natives.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/objects.h View 4 chunks +32 lines, -4 lines 0 comments Download
M src/objects.cc View 11 chunks +41 lines, -43 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 2 chunks +27 lines, -1 line 0 comments Download
A + test/mjsunit/harmony/reflect-set-prototype-of.js View 9 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
5 years, 2 months ago (2015-10-22 09:56:14 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-22 10:38:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417243002/1
5 years, 2 months ago (2015-10-22 10:47:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 11:21:25 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 11:21:48 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c7787ad847ee1d0fdd752b453adac3648b111a6
Cr-Commit-Position: refs/heads/master@{#31465}

Powered by Google App Engine
This is Rietveld 408576698