Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1417223005: EDK: Add mojo_edk_{unit,perf}tests target types. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add mojo_edk_{unit,perf}tests target types. My plan is to split the "enormous" monolithic mojo_system_{unit,perf}tests targets, so this will be helpful in that. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3a02f15082056959144f9cbdfbf5972ce7c45d36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -14 lines) Patch
M mojo/edk/mojo_edk.gni View 2 chunks +73 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 3 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-11-06 20:55:25 UTC) #1
vardhan
lgtm
5 years, 1 month ago (2015-11-06 21:06:37 UTC) #2
viettrungluu
5 years, 1 month ago (2015-11-06 21:23:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a02f15082056959144f9cbdfbf5972ce7c45d36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698