Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ports/curl/build.sh

Issue 1417223003: Switch from using 'nacl_main' to 'main' entry point (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ports/binutils-2.25/build.sh ('K') | « ports/coreutils/build.sh ('k') | ports/curl/nacl.patch » ('j') | ports/font-util/build.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ports/curl/build.sh
diff --git a/ports/curl/build.sh b/ports/curl/build.sh
index 98fc77fdbbcde287b9934d0563ce6a530ce43c26..f519260f53e93b0db9648600233bbd06e5a46cc7 100644
--- a/ports/curl/build.sh
+++ b/ports/curl/build.sh
@@ -8,7 +8,8 @@ export ac_cv_func_connect=yes
# Can't use LIBS here otherwise nacl-spawn gets linked into the libcurl.so
# which we don't ever want.
-export EXTRA_LIBS="${NACL_CLI_MAIN_LIB} -l${NACL_CXX_LIB}"
+export EXTRA_LIBS="${NACL_CLI_MAIN_LIB}"
binji 2015/10/27 21:52:38 Why not EnableCliMain?
Sam Clegg 2015/10/28 17:06:30 The comment above explains why.
+NACLPORTS_LDFLAGS+=" ${NACL_CLI_MAIN_LDFLAGS}"
EnableGlibcCompat
« ports/binutils-2.25/build.sh ('K') | « ports/coreutils/build.sh ('k') | ports/curl/nacl.patch » ('j') | ports/font-util/build.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698