Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417213010: Plugin Power Saver: remove dead flags (Closed)

Created:
5 years, 1 month ago by Dan Beam
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jam, shrike
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: remove dead flags They already didn't do anything, and nobody's been asking to disable this feature (... which they can do via the UI in settings anyways). R=tommycli@chromium.org BUG=none Committed: https://crrev.com/a6ae8e33ddad5a9467e429e7a654c1170f45a2d4 Cr-Commit-Position: refs/heads/master@{#358948}

Patch Set 1 : die flags, die #

Patch Set 2 : gn fix #

Patch Set 3 : more GN fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -97 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M components/content_settings/core/browser/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/plugins.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
D components/plugins/common/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D components/plugins/common/plugins_switches.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/plugins/common/plugins_switches.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Dan Beam
5 years, 1 month ago (2015-11-07 01:11:38 UTC) #3
tommycli
this is a great thing. Thanks! LGTM
5 years, 1 month ago (2015-11-09 17:31:06 UTC) #4
tommycli
On 2015/11/09 17:31:06, tommycli wrote: > this is a great thing. Thanks! LGTM +0 lines ...
5 years, 1 month ago (2015-11-09 17:31:23 UTC) #5
Dan Beam
+brettw@ for OWNERS
5 years, 1 month ago (2015-11-09 19:03:45 UTC) #7
groby-ooo-7-16
On 2015/11/07 01:11:38, Dan Beam wrote: LGTM. Yay code removal!
5 years, 1 month ago (2015-11-09 19:40:56 UTC) #8
Dan Beam
ping brettw
5 years, 1 month ago (2015-11-10 18:55:40 UTC) #9
brettw
lgtm
5 years, 1 month ago (2015-11-10 20:13:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213010/60001
5 years, 1 month ago (2015-11-10 22:05:20 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 1 month ago (2015-11-10 23:22:42 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 23:23:41 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a6ae8e33ddad5a9467e429e7a654c1170f45a2d4
Cr-Commit-Position: refs/heads/master@{#358948}

Powered by Google App Engine
This is Rietveld 408576698