Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html

Issue 1417213006: Switch all LayoutTests to use new AX name calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: refactor stringValueOfControl Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html
diff --git a/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html b/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html
index 5427ae5af88f81222075eedb0f7c54ce2b72b094..599c5e54c9218faef432ec0ed903055298692da8 100644
--- a/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html
+++ b/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html
@@ -22,11 +22,12 @@
text.focus();
text = accessibilityController.focusedElement;
- shouldBe("text.deprecatedDescription", "'AXDescription: Shut down computer after 10 minutes'");
+ shouldBe("text.name", "'Shut down computer after 10 minutes'");
+
+ // The first name element should be the span, not the label element.
+ var firstNameElement = text.nameElementAtIndex(0);
+ shouldBe("firstNameElement.role", "'AXRole: AXUnknown'");
aboxhall 2015/11/06 19:24:11 Not a big deal, but this looks a little flaky now
dmazzoni 2015/11/06 22:32:26 Good idea. I rewrote it to show the label is not
- // There should be no title UI element.
- shouldBe("text.deprecatedTitleUIElement() != null && text.deprecatedTitleUIElement().isValid", "false");
-
var labelElement = accessibilityController.accessibleElementById("labelElement");
// This just makes sure that the label element is still visible in the AX hierarchy, even though
// it's a label element (sometimes they are ignored).

Powered by Google App Engine
This is Rietveld 408576698