Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417213005: Remove several JSFunction delegator functions. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove several JSFunction delegator functions. This removes several methods from JSFunction that just delegate to SharedFunctionInfo. These methods are especially dangerous when they hide the fact that they potentially affect all function instances deriving from the same underlying SharedFunctionInfo. R=bmeurer@chromium.org Committed: https://crrev.com/7890dc4f696db007312499efe21cc14512004c7d Cr-Commit-Position: refs/heads/master@{#31792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -78 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -25 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-04 14:32:28 UTC) #1
Benedikt Meurer
Nice. LGTM :-)
5 years, 1 month ago (2015-11-04 14:33:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213005/1
5 years, 1 month ago (2015-11-04 14:45:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 14:56:16 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 14:56:51 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7890dc4f696db007312499efe21cc14512004c7d
Cr-Commit-Position: refs/heads/master@{#31792}

Powered by Google App Engine
This is Rietveld 408576698