Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1417213004: [turbofan] Use the ArgumentsAdaptorTrampoline in case of argument count mismatch. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use the ArgumentsAdaptorTrampoline in case of argument count mismatch. Call directly into the ArgumentsAdaptorTrampoline when we call a known JSFunction, but that actual argument count doesn't match the expected argument count. R=jarin@chromium.org Committed: https://crrev.com/8339b7620dc17493bcd0b0b5423522709789b505 Cr-Commit-Position: refs/heads/master@{#31781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -20 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +34 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-04 11:29:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a simple patch to also handle the case where actual and expected ...
5 years, 1 month ago (2015-11-04 11:31:31 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-04 11:42:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213004/1
5 years, 1 month ago (2015-11-04 11:46:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 11:53:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 11:53:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8339b7620dc17493bcd0b0b5423522709789b505
Cr-Commit-Position: refs/heads/master@{#31781}

Powered by Google App Engine
This is Rietveld 408576698