Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Issue 1417203006: [Line Layout API] Convert QueryData and descendants to line layout API (Closed)

Created:
5 years, 1 month ago by pilgrim_google
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Convert QueryData and descendants to line layout API This CL affects a lot of code in SVGTextQuery and requires several new API methods in the line layout API. BUG=499321 Committed: https://crrev.com/5c96b9150acdb13102d2be5ac94f95cbffeef4d6 Cr-Commit-Position: refs/heads/master@{#356350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -30 lines) Patch
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutText.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 14 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pilgrim_google
5 years, 1 month ago (2015-10-27 15:59:20 UTC) #2
eae
LGTM
5 years, 1 month ago (2015-10-27 16:40:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417203006/1
5 years, 1 month ago (2015-10-27 16:41:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 18:25:26 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 18:26:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c96b9150acdb13102d2be5ac94f95cbffeef4d6
Cr-Commit-Position: refs/heads/master@{#356350}

Powered by Google App Engine
This is Rietveld 408576698