Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1417203003: Allow IdentityMap to store Smi-0. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow IdentityMap to store Smi-0. R=bmeurer@chromium.org Committed: https://crrev.com/f430bd040f5d518cbbc9cdfffa362bb108f18cf2 Cr-Commit-Position: refs/heads/master@{#31470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/identity-map.cc View 6 chunks +15 lines, -9 lines 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
I created a symbol as sentinel for empty hash table entries. In theory, any address ...
5 years, 2 months ago (2015-10-22 11:34:43 UTC) #1
Benedikt Meurer
Awesome! LGTM
5 years, 2 months ago (2015-10-22 11:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417203003/1
5 years, 2 months ago (2015-10-22 11:36:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6938)
5 years, 2 months ago (2015-10-22 11:39:08 UTC) #6
Yang
Hannes, please take a look at the heap changes, thanks.
5 years, 2 months ago (2015-10-22 11:51:23 UTC) #8
Hannes Payer (out of office)
heap LGTM
5 years, 2 months ago (2015-10-22 11:51:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417203003/1
5 years, 2 months ago (2015-10-22 12:10:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 12:12:15 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 12:12:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f430bd040f5d518cbbc9cdfffa362bb108f18cf2
Cr-Commit-Position: refs/heads/master@{#31470}

Powered by Google App Engine
This is Rietveld 408576698