Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/page/page_benchmark_results_unittest.py

Issue 14172017: [Telemetry] Print summaries for individual passing pages if failed pages exist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed first round of review comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_benchmark_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_benchmark_results_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_benchmark_results_unittest.py b/tools/telemetry/telemetry/page/page_benchmark_results_unittest.py
index e3e20bfd1ea271b41f0561747347a4b07d5a5463..3cbd3b19260a42b062e90ab85eb9bbb2191affbb 100644
--- a/tools/telemetry/telemetry/page/page_benchmark_results_unittest.py
+++ b/tools/telemetry/telemetry/page/page_benchmark_results_unittest.py
@@ -107,6 +107,69 @@ class PageBenchmarkResultsTest(unittest.TestCase):
benchmark_results.results,
expected)
+ def test_basic_summary_pass_and_fail_page(self):
+ """If a page failed, only print summary for individual passing pages."""
+ test_page_set = _MakePageSet()
+
+ benchmark_results = SummarySavingPageBenchmarkResults()
+ benchmark_results.WillMeasurePage(test_page_set.pages[0])
+ benchmark_results.Add('a', 'seconds', 3)
+ benchmark_results.DidMeasurePage()
+ benchmark_results.AddFailure(test_page_set.pages[0], 'message', 'details')
+
+ benchmark_results.WillMeasurePage(test_page_set.pages[1])
+ benchmark_results.Add('a', 'seconds', 7)
+ benchmark_results.DidMeasurePage()
+
+ benchmark_results.PrintSummary(None)
+ expected = ['RESULT a_by_url: http___www.bar.com_= 7 seconds']
+ self.assertEquals(benchmark_results.results, expected)
+
+ def test_basic_summary_all_pages_fail(self):
+ """If all pages fail, no summary is printed."""
+ test_page_set = _MakePageSet()
+
+ benchmark_results = SummarySavingPageBenchmarkResults()
+ benchmark_results.WillMeasurePage(test_page_set.pages[0])
+ benchmark_results.Add('a', 'seconds', 3)
+ benchmark_results.DidMeasurePage()
+ benchmark_results.AddFailure(test_page_set.pages[0], 'message', 'details')
+
+ benchmark_results.WillMeasurePage(test_page_set.pages[1])
+ benchmark_results.Add('a', 'seconds', 7)
+ benchmark_results.DidMeasurePage()
+ benchmark_results.AddFailure(test_page_set.pages[1], 'message', 'details')
+
+ benchmark_results.PrintSummary(None)
+ self.assertEquals(benchmark_results.results, [])
+
+ def test_repeated_pageset_one_iteration_one_page_fails(self):
+ """Page fails on one iteration, no results for that page should print."""
+ test_page_set = _MakePageSet()
+
+ benchmark_results = SummarySavingPageBenchmarkResults()
+ benchmark_results.WillMeasurePage(test_page_set.pages[0])
+ benchmark_results.Add('a', 'seconds', 3)
+ benchmark_results.DidMeasurePage()
+
+ benchmark_results.WillMeasurePage(test_page_set.pages[1])
+ benchmark_results.Add('a', 'seconds', 7)
+ benchmark_results.DidMeasurePage()
+ benchmark_results.AddFailure(test_page_set.pages[1], 'message', 'details')
+
+ benchmark_results.WillMeasurePage(test_page_set.pages[0])
+ benchmark_results.Add('a', 'seconds', 4)
+ benchmark_results.DidMeasurePage()
+
+ benchmark_results.WillMeasurePage(test_page_set.pages[1])
+ benchmark_results.Add('a', 'seconds', 8)
+ benchmark_results.DidMeasurePage()
+
+ benchmark_results.PrintSummary(None)
+ expected = ['RESULT a_by_url: http___www.foo.com_= [3,4] seconds\n' +
+ 'Avg a_by_url: 3.500000seconds\nSd a_by_url: 0.707107seconds']
+ self.assertEquals(benchmark_results.results, expected)
+
def test_repeated_pageset(self):
test_page_set = _MakePageSet()
« no previous file with comments | « tools/telemetry/telemetry/page/page_benchmark_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698