Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 14172016: Enable glibc shared library support for zlib. (Closed)

Created:
7 years, 8 months ago by Sam Clegg
Modified:
7 years, 7 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable glibc shared library support for zlib. Add fPIC for shared builds. Add default validation and translation steps to build process. BUG=https://code.google.com/p/chromium/issues/detail?id=168693& Committed: https://code.google.com/p/naclports/source/detail?r=739

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 16

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -105 lines) Patch
M build_tools/common.sh View 1 2 5 chunks +61 lines, -24 lines 0 comments Download
M examples/games/nethack/nacl-nethack.sh View 1 2 3 2 chunks +5 lines, -13 lines 0 comments Download
M examples/games/snes9x/nacl-snes9x.sh View 1 2 chunks +3 lines, -4 lines 0 comments Download
M examples/graphics/xaos/nacl-xaos.sh View 1 2 3 4 chunks +7 lines, -15 lines 0 comments Download
M examples/systems/bochs/nacl-bochs.sh View 1 2 3 4 chunks +9 lines, -17 lines 0 comments Download
M examples/systems/dosbox/nacl-dosbox.sh View 4 chunks +8 lines, -9 lines 0 comments Download
M libraries/yajl/nacl-yajl.sh View 1 2 3 3 chunks +5 lines, -13 lines 0 comments Download
M libraries/zlib/nacl-zlib.sh View 1 2 3 3 chunks +64 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
First step in getting shared library support in naclports.
7 years, 8 months ago (2013-04-23 21:19:39 UTC) #1
binji
lgtm https://codereview.chromium.org/14172016/diff/18001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/14172016/diff/18001/build_tools/common.sh#newcode693 build_tools/common.sh:693: if [ ${NACL_ARCH} != "pnacl" -a -n "${EXECUTABLES:-}" ...
7 years, 8 months ago (2013-04-23 22:08:59 UTC) #2
Sam Clegg
Committed patchset #4 manually as r739 (presubmit successful).
7 years, 7 months ago (2013-04-26 21:34:52 UTC) #3
Sam Clegg
7 years, 7 months ago (2013-04-26 23:28:10 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/14172016/diff/18001/examples/games/nethack/na...
File examples/games/nethack/nacl-nethack.sh (right):

https://codereview.chromium.org/14172016/diff/18001/examples/games/nethack/na...
examples/games/nethack/nacl-nethack.sh:7: # nacl-nethack-343.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/examples/graphics/xaos/na...
File examples/graphics/xaos/nacl-xaos.sh (right):

https://codereview.chromium.org/14172016/diff/18001/examples/graphics/xaos/na...
examples/graphics/xaos/nacl-xaos.sh:7: # nacl-xaos.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/examples/systems/bochs/na...
File examples/systems/bochs/nacl-bochs.sh (right):

https://codereview.chromium.org/14172016/diff/18001/examples/systems/bochs/na...
examples/systems/bochs/nacl-bochs.sh:7: # nacl-bochs.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/libraries/yajl/nacl-yajl.sh
File libraries/yajl/nacl-yajl.sh (right):

https://codereview.chromium.org/14172016/diff/18001/libraries/yajl/nacl-yajl....
libraries/yajl/nacl-yajl.sh:7: # nacl-yajl.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/libraries/zlib/nacl-zlib.sh
File libraries/zlib/nacl-zlib.sh (right):

https://codereview.chromium.org/14172016/diff/18001/libraries/zlib/nacl-zlib....
libraries/zlib/nacl-zlib.sh:7: # nacl-zlib-1.2.3.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/libraries/zlib/nacl-zlib....
libraries/zlib/nacl-zlib.sh:7: # nacl-zlib-1.2.3.sh
On 2013/04/23 22:08:59, binji wrote:
> remove

Done.

https://codereview.chromium.org/14172016/diff/18001/libraries/zlib/nacl-zlib....
libraries/zlib/nacl-zlib.sh:90: CustomConfigureStep shared
On 2013/04/23 22:08:59, binji wrote:
> doesn't need to clean?

DefaultBuildStep always does a clean first.

Powered by Google App Engine
This is Rietveld 408576698