Issue 14172015: Merge 194003 "Suppress CHECK failure in CreateProfile for OS_WIN."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14172015: Merge 194003 "Suppress CHECK failure in CreateProfile for OS_WIN." (Closed)

Created:
7 years, 8 months ago by hshi1

Modified:
7 years, 8 months ago

Reviewers:
hshi1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

More Reviews

Description

Merge 194003 "Suppress CHECK failure in CreateProfile for OS_WIN." > Suppress CHECK failure in CreateProfile for OS_WIN. > > The CHECK(profile) was only intended for platforms other than Windows. > Prior to my fix for bug 196301, the intended behavior is for CreateProfile > to return NULL and allow Chrome to normally exit, because after showing > the user data dir picker dialog we would have already re-launched Chrome > with a new command line containing the correct user data dir. > > BUG=230442 > TEST=CQ > > Review URL: https://chromiumcodereview.appspot.com/14109008 TBR=hshi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194406

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r194406.

Expand Messages | Collapse Messages