Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 14172003: Move Chromium's TestExpectations and ContentShellTestExpectations to generic location (Closed)

Created:
7 years, 8 months ago by Steve Block
Modified:
7 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Move Chromium's TestExpectations and ContentShellTestExpectations to generic location BUG=230264 R=dpranke,jparent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148348

Patch Set 1 #

Patch Set 2 : Updated a comment #

Total comments: 2

Patch Set 3 : Removed change to loader.js #

Total comments: 1

Patch Set 4 : Removed change to ContentShellTestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3790 lines) Patch
A + LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-android/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/chromium/TestExpectations View 1 2 1 chunk +0 lines, -3786 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Steve Block
This depends on https://codereview.chromium.org/14047003 Adding jparent for loader.js
7 years, 8 months ago (2013-04-11 12:10:20 UTC) #1
Julie Parent
https://codereview.chromium.org/14172003/diff/2001/Tools/TestResultServer/static-dashboards/loader.js File Tools/TestResultServer/static-dashboards/loader.js (right): https://codereview.chromium.org/14172003/diff/2001/Tools/TestResultServer/static-dashboards/loader.js#newcode36 Tools/TestResultServer/static-dashboards/loader.js:36: var CHROMIUM_EXPECTATIONS_URL = 'http://svn.webkit.org/repository/webkit/trunk/LayoutTests/TestExpectations'; The dashboards definitely need to ...
7 years, 8 months ago (2013-04-11 22:40:13 UTC) #2
Steve Block
https://codereview.chromium.org/14172003/diff/2001/Tools/TestResultServer/static-dashboards/loader.js File Tools/TestResultServer/static-dashboards/loader.js (right): https://codereview.chromium.org/14172003/diff/2001/Tools/TestResultServer/static-dashboards/loader.js#newcode36 Tools/TestResultServer/static-dashboards/loader.js:36: var CHROMIUM_EXPECTATIONS_URL = 'http://svn.webkit.org/repository/webkit/trunk/LayoutTests/TestExpectations'; OK, thanks. I'll remove my ...
7 years, 8 months ago (2013-04-11 23:54:45 UTC) #3
abarth-chromium
https://codereview.chromium.org/14172003/diff/8001/LayoutTests/platform/chromium-mac-mountainlion/TestExpectations File LayoutTests/platform/chromium-mac-mountainlion/TestExpectations (left): https://codereview.chromium.org/14172003/diff/8001/LayoutTests/platform/chromium-mac-mountainlion/TestExpectations#oldcode3 LayoutTests/platform/chromium-mac-mountainlion/TestExpectations:3: # passing cleanly on Mountain Lion. Maybe we should ...
7 years, 8 months ago (2013-04-12 02:07:26 UTC) #4
Dirk Pranke
lgtm, except that you can't move ContentShellTestExpectations w/o updating the bot to know about the ...
7 years, 8 months ago (2013-04-12 02:12:00 UTC) #5
Dirk Pranke
On 2013/04/12 02:12:00, Dirk Pranke wrote: > lgtm, except that you can't move ContentShellTestExpectations w/o ...
7 years, 8 months ago (2013-04-12 02:12:37 UTC) #6
Steve Block
> Maybe we should just delete this file? Will do so in a prerequisite change. ...
7 years, 8 months ago (2013-04-12 02:18:47 UTC) #7
Steve Block
7 years, 8 months ago (2013-04-15 01:56:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r148348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698