components/content_settings/core/browser/content_settings_registry.cc - Issue 1417173010: Adding <keygen> Content Setting (core)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 1417173010: Adding <keygen> Content Setting (core) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing ContentSetting Register. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_policy_provider.cc ('k') | components/content_settings/core/common/content_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.cc

diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc

index a5974d4497374edb130cdcca93de90ae701a9a9c..4ca3eb5d1d2a9ec74d1fe705b14e45490bca5ff5 100644

--- a/components/content_settings/core/browser/content_settings_registry.cc

+++ b/components/content_settings/core/browser/content_settings_registry.cc

@@ -234,6 +234,12 @@ void ContentSettingsRegistry::Init() {

ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK),

WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE);

+ Register(CONTENT_SETTINGS_TYPE_KEYGEN, "keygen",

+ CONTENT_SETTING_BLOCK, WebsiteSettingsInfo::SYNCABLE,

+ WhitelistedSchemes(),

+ ValidSettings(CONTENT_SETTING_ALLOW, CONTENT_SETTING_BLOCK),

+ WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE);

// Content settings that aren't used to store any data. TODO(raymes): use a

// different mechanism rather than content settings to represent these.

// Since nothing is stored in them, there is no real point in them being a