third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html - Issue 1417173002: Devtools Animations: Pause button based on groups not global

Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html

Issue 1417173002: Devtools Animations: Pause button based on groups not global (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html ('k') | third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

	4 <script>

	5

	6 var animation;

	7

	8 function startAnimation()

	9 {

	10 animation = node.animate([{ width: "100px" }, { width: "200px" }], 2000);

	11 }

	12

	13 function getWidth()

	14 {

	15 return node.offsetWidth;

	16 }

	17

	18 function test()

	19 {

	20 InspectorTest.eventHandler["Animation.animationStarted"] = onStarted;

	21 InspectorTest.sendCommand("Animation.enable", {});

	22 InspectorTest.evaluateInPage("startAnimation()", function() {});

	23

	24 function onStarted(response)

	25 {

	26 InspectorTest.log("Animation started");

	27 InspectorTest.evaluateInPage("logPaused()");

	28 InspectorTest.sendCommand("Animation.setPaused", { animations: [ respons e.params.animation.id ], paused: true }, animPaused);

	29 }

	30

	31 function animPaused()

	32 {

	33 InspectorTest.evaluateInPage("getWidth()", saveWidth);

	34 }

	35

	36 var width;

	37 function saveWidth(result)

	38 {

	39 width = result;

	40 // Allow some frames to be painted to ensure it stays paused.

	41 setTimeout(InspectorTest.evaluateInPage.bind(InspectorTest, "getWidth()" , checkWidth), 50);
	pfeldman 2015/10/21 22:53:10 timeout is in most cases a source of the flake. th timeout is in most cases a source of the flake. there is no guarantee you get frames, etc. What are you trying to simulate here? samli 2015/10/21 22:54:21 That it is indeed truly paused. Show quoted text On 2015/10/21 at 22:53:10, pfeldman_slow wrote: > timeout is in most cases a source of the flake. there is no guarantee you get frames, etc. What are you trying to simulate here? That it is indeed truly paused. pfeldman 2015/10/26 18:20:50 But 50 gives you nothing, it could result in 0 or But 50 gives you nothing, it could result in 0 or 10000. And that is the front-end timer that is not in sync with the page. Wouldn't setPaused pause synchronously? If so, should you call getWidth right after? Where is asynchrony coming from? samli 2015/10/26 18:30:49 If its correctly paused, it doesn't matter if I me Show quoted text On 2015/10/26 at 18:20:50, pfeldman wrote: > But 50 gives you nothing, it could result in 0 or 10000. And that is the front-end timer that is not in sync with the page. Wouldn't setPaused pause synchronously? If so, should you call getWidth right after? Where is asynchrony coming from? If its correctly paused, it doesn't matter if I measure 0 or 10000ms later. setPaused does pause synchronously. I do call getWidth() immediately, and that just tells me what the width is, but I have no guarantee when I initially called setPaused(). What I'm testing is that if the animation did NOT pause, then with some change in time, the element would move. No frames are required to be painted, just the passing of time. We don't have any other public API to test it is synchronously paused, and since I'm using clones on top of original animations, testing the actual element is the best sanity check I can perform. asynchrony = passing of time for the animation in the fail case.
	42 }

	43

	44 function checkWidth(result)

	45 {

	46 InspectorTest.log(result == width);

	47 InspectorTest.completeTest();

	48 }

	49

	50 }

	51

	52 </script>

	53 </head>

	54 <body onload="runTest()">

	55 Tests that the animation is correctly paused.

	56 <div id="node" style="background-color: red; height: 100px"></div>

	57 </body>

	58 </html>

OLD	NEW