Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417163004: Remove obsolete src/v8.h include from compiler cctests. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-cctest-api-deprecation
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete src/v8.h include from compiler cctests. R=jochen@chromium.org Committed: https://crrev.com/9ada38b4c6586c7bce469eda173452f3ccf4fd4b Cr-Commit-Position: refs/heads/master@{#31632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -67 lines) Patch
M test/cctest/compiler/call-tester.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-stackcheck.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1408283006 Patch 1

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-28 12:48:52 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-28 12:51:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417163004/1
5 years, 1 month ago (2015-10-28 13:30:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 13:32:20 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 13:32:35 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ada38b4c6586c7bce469eda173452f3ccf4fd4b
Cr-Commit-Position: refs/heads/master@{#31632}

Powered by Google App Engine
This is Rietveld 408576698