Issue 1417143003: Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417143003: Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results. This improves warm VM analysis time (i.e. 99% of all analyzis that happens in IDEs) from 7200 ms to 6600 ms. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c43f292dd9f4bbb708756d0e1b56bdfac2f6ecdc

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -318 lines)			Patch
M	pkg/analysis_server/lib/src/status/get_handler.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	7 chunks	+75 lines, -56 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	5 chunks	+1 line, -103 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/driver.dart	View	4 chunks	+30 lines, -25 lines	0 comments	Download
M	pkg/analyzer/lib/task/dart.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	3 chunks	+0 lines, -110 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 2 months ago (2015-10-24 15:35:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c43f292dd9f4bbb708756d0e1b56bdfac2f6ecdc (presubmit successful).