Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: dart/tools/testing/dart/test_options.dart

Issue 141713002: Outline of how to factor out compiler and runtime specifics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address Martin's comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_options.dart
diff --git a/dart/tools/testing/dart/test_options.dart b/dart/tools/testing/dart/test_options.dart
index a9b407ed3896ea669446b576035cfd1246e34379..6e0a2a57c22d0e5a0287a00e2def80cd03535fe3 100644
--- a/dart/tools/testing/dart/test_options.dart
+++ b/dart/tools/testing/dart/test_options.dart
@@ -7,6 +7,8 @@ library test_options_parser;
import "dart:io";
import "drt_updater.dart";
import "test_suite.dart";
+import "compiler_configuration.dart" show CompilerConfiguration;
+import "runtime_configuration.dart" show RuntimeConfiguration;
List<String> defaultTestSelectors =
const ['samples', 'standalone', 'corelib', 'co19', 'language',
@@ -709,45 +711,17 @@ Note: currently only implemented for dart2js.''',
// Adjust default timeout based on mode, compiler, and sometimes runtime.
if (configuration['timeout'] == -1) {
- var timeout = 60;
- switch (configuration['compiler']) {
- case 'dartanalyzer':
- case 'dart2analyzer':
- timeout *= 4;
- break;
- case 'dart2js':
- // TODO(ahe): Restore the timeout of 30 seconds when dart2js
- // compile-time performance has improved.
- timeout = 60;
- if (configuration['mode'] == 'debug') {
- timeout *= 8;
- }
- if (configuration['host_checked']) {
- timeout *= 16;
- }
- if (configuration['checked']) {
- timeout *= 2;
- }
- break;
- default:
- if (configuration['arch'] == 'simarm') {
- timeout *= 4;
- } else if (configuration['arch'] == 'arm') {
- timeout *= 4;
- } else if (configuration['arch'] == 'simmips') {
- timeout *= 4;
- } else if (configuration['arch'] == 'mips') {
- timeout *= 4;
- }
- if (configuration['mode'] == 'debug') {
- timeout *= 2;
- }
- if (const ['drt'].contains(configuration['runtime'])) {
- timeout *= 4; // Allow additional time for browser testing to run.
- }
- break;
- }
- configuration['timeout'] = timeout;
+ int compilerMulitiplier =
+ new CompilerConfiguration(configuration).computeTimeoutMultiplier(
+ isDebug: configuration['mode'] == 'debug',
+ isChecked: configuration['checked'],
+ isHostChecked: configuration['host_checked']);
+ int runtimeMultiplier =
+ new RuntimeConfiguration(configuration).computeTimeoutMultiplier(
+ isDebug: configuration['mode'] == 'debug',
+ isChecked: configuration['checked'],
+ arch: configuration['arch']);
+ configuration['timeout'] = 60 * compilerMulitiplier * runtimeMultiplier;
}
return [configuration];
« no previous file with comments | « dart/tools/testing/dart/runtime_configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698