Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1417103003: Use getAttribute to sample 'd' attribute in interpolation-test.js (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use getAttribute to sample 'd' attribute in interpolation-test.js pathSegList is going away, so use getAttribute('d') instead. Adjust some expectations - mostly for 'z' vs 'Z' (not possible to discern after parsing.) BUG=539385 Committed: https://crrev.com/2c4120b77968ad3825101ed287726575b87ef8d8 Cr-Commit-Position: refs/heads/master@{#355476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -177 lines) Patch
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 4 chunks +2 lines, -132 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation.html View 3 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation-expected.txt View 3 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 2 months ago (2015-10-21 19:24:49 UTC) #2
Eric Willigers
lgtm
5 years, 2 months ago (2015-10-22 01:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417103003/1
5 years, 2 months ago (2015-10-22 01:52:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 01:56:53 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 01:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c4120b77968ad3825101ed287726575b87ef8d8
Cr-Commit-Position: refs/heads/master@{#355476}

Powered by Google App Engine
This is Rietveld 408576698